[cups.development] Re: [cups.commit] [CUPS] r5785 - branches/kerberos/cups

[Michael Sweet]

Warning: nitpicking ahead... :)

 > ...
> Modified: branches/kerberos/cups/http-private.h
> ===================================================================
> --- branches/kerberos/cups/http-private.h	2006-08-01 00:25:46 UTC (rev 5784)
> +++ branches/kerberos/cups/http-private.h	2006-08-01 01:28:30 UTC (rev 5785)
> @@ -166,6 +166,10 @@
>    char			wbuffer[HTTP_MAX_BUFFER];
>  					/* Buffer for outgoing data */
>    int			wused;		/* Write buffer bytes used @since CUPS 1.2@ */
> +  char			field_www_authenticate[2048]; 
> +					/* WWW-Authenticate field. @since CUPS 1.?@ 
> +					 * Required because of limitations on the value length
> +					 * in fields. */

In the interest of keeping memory usage low, could you change this
to char * and strdup() and free() the string as needed?

Also, you need to update the httpClearFields() function so that it
clears the new field_www_authenticate member.

Finally, httpUpdate() needs to strlcpy() the WWW-Authenticate field
to the old location for binary compatibility, even if the field gets
truncated...

-- 
______________________________________________________________________
Michael Sweet, Easy Software Products           mike at easysw dot com
Internet Printing and Publishing Software        http://www.easysw.com