[cups.bugs] [HIGH] STR #2023: cups-lpd doesn't set 'job-originating-host-name'

[Martin Harriss]

[STR New]

Looks like this broke when the '-n' option was added.  Here is the fix:

# diff -c cups-lpd.c.1.2.4 cups-lpd.c
*** cups-lpd.c.1.2.4    2006-08-24 11:55:42.000000000 -0400
--- cups-lpd.c  2006-10-11 14:19:49.000000000 -0400
***************
*** 150,157 ****
    num_defaults = 0;
    defaults     = NULL;
    hostlookups  = 1;
-   num_defaults = cupsAddOption("job-originating-host-name", hostname,
-                                num_defaults, &defaults);

    for (i = 1; i < argc; i ++)
      if (argv[i][0] == '-')
--- 150,155 ----
***************
*** 206,211 ****
--- 204,212 ----
      else
        strlcpy(hostname, hostip, sizeof(hostname));

+   num_defaults = cupsAddOption("job-originating-host-name", hostname,
+                                num_defaults, &defaults);
+
  #ifdef AF_INET6
      if (hostaddr.addr.sa_family == AF_INET6)
        hostfamily = "IPv6";

Link: http://www.cups.org/str.php?L2023
Version: 1.2.4