[cups.development] [RFE] STR #2358: ppdFindOption()performanceimprovement using hash table lookup

Michael Sweet mike at easysw.com
Thu Apr 26 20:39:07 PDT 2007


Hidetomo Katsura wrote:
> just a heads up. i broke the case-insensitivity (assuming PPD is
> case-insensitive) when i added the hash table lookup to my cups lib (i didn't
> run into any problems or anything because all my PPD files have the correct
> cases).
> 
> Michael, please make sure you didn't break the case-insensitivity of options
> and choices (or whatever you are using the hash).
> 
> i guess the hash value function just need to be changed to convert the input
> string to lowercase (each character to a lowercase) in order to keep the
> case-insensitivity.

I'll make sure to update the code to do a toupper (tolower spreads
the letters away from the numbers, which reduces the effectiveness
of the hash...)

-- 
______________________________________________________________________
Michael Sweet, Easy Software Products           mike at easysw dot com
Internet Printing and Publishing Software        http://www.easysw.com




More information about the cups-devel mailing list