[HIGH] STR #2459: Patch to allow comment chars inpasswordfields

[Daniel M. Lambea]

As per RFC 2396:

"
[...]
2.4.2. When to Escape and Unescape

   A URI is always in an "escaped" form, since escaping or unescaping a
   completed URI might change its semantics.  Normally, the only time
   escape encodings can safely be made is when the URI is being created
   from its component parts;
[...]
"

As I see, CUPS is receiving the complete URI. So it must have been escaped in the source. Also, when sent to e.g. SAMBA, it should be sent in escaped form. Now I don't see any reason CUPS to be patched with escape/unescape code. The source of my problem is now transferred to KDE's Printer Wizard, and the samba interface.

Many thanks for your support.
  Daniel M. Lambea

> I tested it with no success. I changed the '#' to "%23", but it doesn't work. I try a test page print, and the job holds with the following in the error log: "Session setup failed: NT_STATUS_LOGON_FAILURE". If I switch back to the '#' char, the job prints correctly.
>
> > My suggestion was not about changing your patch. My suggestion was about
> > changing your device URI in your *existing* smb:// print queue by re-
> > writing it according to the URL encoding rules.... and see if this helps
> > for your cause *now* (without patching anything).
>