[cups.bugs] [HIGH] STR #2831: %%IncludeFeature: functionality not working correctly

[Scott Balneaves]

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Per OpenOffice bug #65491:
http://www.openoffice.org/issues/show_bug.cgi?id=65491

OpenOffice moved from a %%BeginFeature/%%EndFeature to an %%IncludeFeature
style for selecting features to include.  Notibly (in my case) selecting
InputSlots for multibin printing (we work in an office environment, and
it's quite common to have a document that has the first page pulling
letterhead from bin 2, plain from bin 3, and an envelope from the envelope
feeder)

I think I've found 2 problems with the pstops filter:

1) doc_setup was being called before the search for IncludeFeatures was
being run.  Therefore, options that were added after the doc_setup weren't
being cupsMark'd and ppdEmit'd  Fixed this by moving the doc_setup call to
after the search and insert_feature calls.
2) No search for IncludeFeatures was being done in the
%%BeginPageSetup/%%EndPageSetup region.  So, if the input tray was changed
for one page, it wasn't being picked up at all.  Fixed this by moving the
search code earlier, and adding a check for %%IncludeFeature

I've attached a patch.

Oh, BTW, tell Till Scott says Hi! :)

Cheers!
Scott

Link: http://www.cups.org/str.php?L2831
Version: 1.3.7
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pstops.patch
URL: <http://lists.cups.org/pipermail/cups-devel/attachments/20080523/52aaf6e6/attachment.ksh>