malloc without NULL check

andreas moroder andreas.moroder at sb-brixen.it
Sun May 25 02:29:25 PDT 2008


> andreas moroder wrote:
> > ...
> > and more in other places in cups-1.4svn-r7613
>
Hello,

I did not want to criticise, I only wanted to help to get a even better code.

> First, a NULL will just cause the filter to crash, stopping the job.

and the sysadmin will never know why

>
> Second, if malloc() fails there is nothing we'll be able to do other
> than exit with a non-zero exit status, stopping the job.

In many places in the source as in image-bmp.c this already happens

Bye
Andreas




More information about the cups-devel mailing list