[cups.bugs] [HIGH] STR #3091: scheduler/job.c:load_job_cache() shouldn't discard attrs of completed jobs

[Lothar Brendel]

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

When loading the job data from /var/cache/cups/job.cache and
/var/spool/cups/c*, load_job_cache() calls cupsdLoadJob() only for jobs
with a state of IPP_JOB_STOPPED or below (i.e. not for IPP_JOB_COMPLETED).
Thus, completed jobs from the cache are left with their attrs=NULL, which
IMHO is the situation which Mike called a "serious problem with the
system" in http://www.cups.org/str.php?L3030+P0+S0+C0+I0+E0+M20+Q3030.

Just to remind: When scheduler/quotas.c:cupsdUpdateQuota() scans the past
jobs for summing up pages and kilobytes, it stops as soon as it encounters
a job w/o time-at-* attributes.

IMHO this breaks the quota system (hence priority 4) unless none of the
past (completed) jobs comes from the cache.

Link: http://www.cups.org/str.php?L3091
Version: 1.3.9