[cups.bugs] [LOW] STR #3407: cupsdLoadJob() returns success in out of memory condition

twaugh.redhat twaugh at redhat.com
Tue Nov 3 04:56:03 PST 2009


DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

In scheduler/job.c, line 1660 (branch-1.4), this code returns success when
there is not enough memory to load the job completely:

    if (!compressions || !filetypes)
    {
      cupsdLogMessage(CUPSD_LOG_ERROR,
                      "[Job %d] Ran out of memory for job file types!",
                      job->id);
>>>   return (1);
    }

I think it should probably free all resources allocated to that point and
return 0.

(Originally part of STR #3078.)

Link: http://www.cups.org/str.php?L3407
Version: 1.4.1





More information about the cups-devel mailing list