[cups.bugs] [LOW] STR #3797: gziptoany: ferror() does not return an error code

twaugh.redhat twaugh at redhat.com
Fri Feb 18 03:54:59 PST 2011


DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

This code in filter/gziptoany.c is wrong:

        fprintf(stderr,
                _("ERROR: Unable to write uncompressed document data:
%s\n"),
                strerror(ferror(stdout)));

You cannot call strerror() on the result of ferror(); ferror() simply
returns zero or non-zero.  I'd suggest simply:

fputs(_("ERROR: Unable to write uncompressed document data\n"), stderr);

Link: http://www.cups.org/str.php?L3797
Version: 1.4.6





More information about the cups-devel mailing list