[cups.bugs] runloop.c: 2 * bad if tests

Michael Sweet msweet at apple.com
Mon Aug 27 18:59:08 PDT 2012


David,

Please file a bug:

    http://www.cups.org/str.php


On Aug 27, 2012, at 2:47 PM, David Binderman <dcb314 at hotmail.com> wrote:

> 
> I just tried a compile of cups-1.6.1 with
> extra compiler flag -Wlogical-op.
> 
> The compiler said
> 
> runloop.c: In function 'backendDrainOutput':
> runloop.c:93:7: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
>       if (errno != EAGAIN || errno != EINTR)
>       ^
> runloop.c: In function 'backendRunLoop':
> runloop.c:321:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
>  if (errno != EAGAIN || errno != EINTR)
>  ^
> 
> Suggest swap || for &&
> 
> _______________________________________________
> cups-bugs mailing list
> cups-bugs at easysw.com
> http://lists.easysw.com/mailman/listinfo/cups-bugs

__________________________________________________
Michael Sweet, Senior Printing System Engineer, PWG Chair





More information about the cups-devel mailing list