[cups-devel] [UNKN] STR #4447: Missing "break" in backendNetworkSideCB

[Peter De Wachter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

The CUPS_SC_CMD_GET_DEVICE_ID case in the big switch in the
backendNetworkSideCB function is missing a break statament. If snmp_fd < 0
and getenv("1284DEVICEID") fails, the code will fall through to the next
case, which doesn't seem to be correct behavior. Noticed by chance while
browsing the code.

Link: https://www.cups.org/str.php?L4447
Version: 1.7-current
Attachment: https://www.cups.org/strfiles.php/3359/cups-missing-break.diff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJTsdvzAAoJENujp6sI12Ij2WQQAJkfHmaMJOxsfECpxQ1A3+Xg
vK6D6usYIgGlGFCjKrgxjchVbJhWjhwrk+6A9+mInNI/0PO4Xy4CBCNl+qtKgLSr
2631rxr5XUtRmJ0o7O3EHaEG+jfz4qVQEzDwVF2VzVUOQm1/TiwPemLkIkJ4nD6o
dBGfJtLjbohwBBU5Ni+i+zABqrJJFjBYjIx0MNk+FGxUHjA92Xtf7qyTJpJjiziD
kSS6DKIxa0cYGmZnHRN49lu8pUJ9ViXH7DIkC7D5uxUu29t1AqexMOBcQPv/H8qC
IdHUKao1VOyk99LYzbCP4KqKL4SjvKjBTAEe7YYOAQ1nJIbZwA+HvaIqz0zJFI/Q
VG2l7Mxaw22i+MqGgobhK1wYx+do0oIyT/Zqa5P3L5yeJk2zOj3dmM2VdXFh43aO
Ku8e1wURoBWPpXp/A/+wyRLYCr+KsyashZLEe1+EgCc3haQIPoRJVXquieBTK7qo
4+ZR5DhtUnKV6UqmyvXeVzHsvhUvzQtziDDXViCk5YJEN4sF6hBXDg/iZsdUd1KY
lyAbQ5ZMBEzDu3ZdiNxEbVljYWSMDNQIIrrF2hzE8g2K4EW63lPqKJyR9Gw1GqBY
06BRlFLfrluv5KbsMp8v5u26lNHz3Wj90EswhgCcCGUusWSiC0gNkt+g0KxSQElz
kzPf22NgGZsyjjU1/yOf
=dUtt
-----END PGP SIGNATURE-----