[cups-devel] [LOW] STR #4430: lpr -l (raw printing) broken

[Didier Raboud]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR Unresolved]

This got reported in Debian as https://bugs.debian.org/771259.

Given the versions Brian has reported as working (and not-working); I've
tried rebuilding Debian's latest version with the following patch:

- --- a/scheduler/job.c
+++ b/scheduler/job.c
@@ -705,8 +705,9 @@
   * Add decompression/raw filter as needed...
   */

- -  if (job->compressions[job->current_file] &&
- -      (!job->printer->remote || job->num_files == 1))
+  if ((!job->printer->raw && job->compressions[job->current_file]) ||
+      (!filters && !job->printer->remote &&
+       (job->num_files > 1 || !strncmp(job->printer->device_uri, "file:",
5))))
   {
    /*
     * Add gziptoany filter to the front of the list...


It's a revert of the 1.7.1 change referred as follows:

> Printing to a raw queue could result in corrupt output due to
opportunistic compression (<rdar://problem/15008524>)

Applying the above patch works, I'd love your feedback on this potential
revert though.

Cheers, OdyX

Link: https://www.cups.org/str.php?L4430
Version: 1.7.1
Fix Version: Third-party
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJUeG2cAAoJENujp6sI12IjiG0P/RCZLOpetGNcCYIfPnQc+its
bskJO54IM2TgBusXzbEoAWGW0ediF2cJpsXN9TO1JsObI0nOnIfwevREQDGAcBZI
RldCTrIndRHDZ9oV4QX4WknBx7Tk8sSUI66AkZR9aL6aJUyu9SIRjxXE4YLYf9x6
auFHhtz+fdbTrMVbHv9gZEZVQi1OuspATMXPcoBWQzr62MZ7u5530f4tByd2qnsD
FtfQoq4mdnAkLp9/tdvW/SP0DtuFpMOUnsoLLQrvyF7E8l6dbyLbHDJIVMxl4zmh
+bv3aoBcH1c6lGBHOkH/Hzep9qrRVYIP8ap9hvMjYbyhwUK82cxjLQaUu4IwkuVV
cC19LcRPKliF+jlwFCXz1DJrCGGJXdqCMw4bKEpCm1smViVHyi5mXXLTEWSCziOF
H6dZk4zU9QX5SHGpisf0GTaABtNdYEA1KnmNYEautVzWdo09SSlHKUVOvlZxHEvv
O1HucLitrPSFYuPkZ7RWFUJjsNiYOUDmOIIjEUUvKO2LcFCM98nL4zaUiS0h6gLN
Nc01qUQx88t0BmZL0FSOwwZPXTvZjqrk7jNLSWudtisJhnQx0keKcf1pSHSQajDs
GCIPvLc1+PeIcvAaqhSfE8psj/89QogVRFzRlGKXY1zep0Xui9LEyrHnw/KBcwZz
ELP77YhKCPxrjtP54k4c
=zy1U
-----END PGP SIGNATURE-----