[cups.general] [patch] IPP_PORT setting

Michael Sweet mike at easysw.com
Tue Aug 10 05:44:17 PDT 2004


Tim Waugh wrote:
> Here is a small patch to prevent the IPP backend from using the port
> that the scheduler is configured to use.  Even when the scheduler is
> configured to use a non-standard IPP port, the IPP backend should be
> using port 631.
> 
> Tim.
> */
> 
> --- cups-1.1.21rc1/scheduler/job.c~	2004-08-05 12:41:58.866939832 -0400
> +++ cups-1.1.21rc1/scheduler/job.c	2004-08-05 14:12:35.093507776 -0400
> @@ -1706,7 +1706,7 @@
>    snprintf(tmpdir, sizeof(tmpdir), "TMPDIR=%s", TempDir);
>    snprintf(datadir, sizeof(datadir), "CUPS_DATADIR=%s", DataDir);
>    snprintf(fontpath, sizeof(fontpath), "CUPS_FONTPATH=%s", FontPath);
> -  sprintf(ipp_port, "IPP_PORT=%d", LocalPort);
> +  sprintf(ipp_port, "IPP_PORT=%d", ippPort());

Hmm, the purpose of this was to allow for filters that needed to
communicate with the scheduler to do so; changing it will prevent
it.

I would say we probably want to use ippSetPort(IPP_PORT) in the
IPP backend instead; that will get the behavior you desire without
impacting the filters.  We could also look at updating httpSeparate()
to not use the ippPort() value, but that would have a much wider
scope so I'd want to do a full audit to see what programs are
using the port value from it...

-- 
______________________________________________________________________
Michael Sweet, Easy Software Products           mike at easysw dot com
Printing Software for UNIX                       http://www.easysw.com




More information about the cups mailing list