[cups.development] Re: [RFE] STR #1634: [PATCH] ijs/make install fix: check for dirs in the right place

[Bernhard Rosenkraenzer]

[STR Closed w/Resolution]

The patch is wrong, because "test -z" simply checks if the variable is
empty, not if anything exists.

Given that, not including DESTDIR in the check is the right thing to do,
because in the case of e.g. bindir being empty and DESTDIR being
/tmp/espgs-root, test -z "$(DESTDIR)/$(bindir)" || $(mkdir_p)
"$(DESTDIR)/$(bindir)"
would result in a superfluous mkdir -p $(DESTDIR) [DESTDIR is created
earlier], while test -z "$(bindir)" || $(mkdir_p) "$(DESTDIR)/$(bindir)"
results in (correctly) nothing being done.


Adding DESTDIR would be the right thing to do if this were a "test -d"
statement rather than a "test -z" one.

Link: http://www.cups.org/str.php?L1634
Version: 8.15-feature
Fix Version: 8.15-feature