[cups.bugs] Re: [LOW] STR #1733: ldap modify doesn't work

[Michael Sweet]

Dirk Kastens wrote:
> Mike,
> 
> Michael Sweet schrieb:
>> [STR Closed w/Resolution]
>>
>> Fixed in Subversion repository.
>>
>> Link: http://www.cups.org/str.php?L1733
>> Version: 1.2.1
>> Fix Version: 1.3-current (r5602)
> 
> Your patch now adds an ldap printer with two cn values: the printer name 
> and the printer description. I made two changes, so that the ldap 
> printer will be created with only one cn: the printer name:
> 
> 2682c2682
> <   cn_value[0]   = p->info;
> ---
>  >   cn_value[0]   = p->name;
> 2696c2696
> <            "(&(objectclass=cupsPrinter)(printerDescription~=%s))", 
> p->info);
> ---
>  >            "(&(objectclass=cupsPrinter)(cn=%s))", p->name);

Actually, we *should* be filtering on the printerURI, as the name is
not unique by itself...  I've commited your cn_value[0] change and
changed the filter string to use printerURI instead of cn.

-- 
______________________________________________________________________
Michael Sweet, Easy Software Products           mike at easysw dot com
Internet Printing and Document Software          http://www.easysw.com