[cups.bugs] [MOD] STR #2093: dns-sd: High cpu usage with empty BrowseRemoteProtocols

jlovell.apple jlovell at apple.com
Fri Nov 10 11:32:38 PST 2006


DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE
LINK BELOW.

[STR New]

This is on the dns-sd branch...
- An empty BrowseRemoteProtocols can cause high cpu usage.
- Two strings are being released incorrectly corrupting the heap.
- Change fax queue registration type since it requires an extra value to
function (i.e. a phone number).

scheduler/dirsvc.c:
- process_browse_data(): Set state directly since cupsdSetPrinterState()
ignores remote printers (as is done on trunk).
- dnssdDeregisterPrinter(): Release txt_record with free(), not
cupsdClearString().
- dnssdRegisterPrinter(): Release name with cupsdClearString(), not
free().
- cupsdSaveRemoteCache(): "Saving remote.cache..." is a debug log message.

main.c:
- main(): Calling DNSServiceProcessResult() is predicated on
BrowseLocalProtocols, not BrowseRemoteProtocols.
- main(): Update the root certificate before calling cupsdReadClient()
(seems like this change it should go onto trunk too).

Thanks!

Link: http://www.cups.org/str.php?L2093
Version: 1.2-feature
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dns-sd.patch
URL: <https://lists.cups.org/pipermail/cups/attachments/20061110/5725ee03/attachment.ksh>


More information about the cups mailing list