[cups.bugs] [MOD] STR #1954: Any backend error causes the queue to be put on hold

jlovell.apple jlovell at apple.com
Thu Sep 14 11:04:28 PDT 2006


[STR Closed w/Resolution]

The third times the charm... str1954-3.patch attached (which was applied to
the 1.2 branch).

Comments:

The code and documentation differed on the error policy cancel-job v.s.
abort-job -- I went abort-job (cancel seems to be a user action).

printers.c:
- cupsdStopPrinter() wasn't generating the job-stopped event.

job.c:
- cupsdFinishJob():
    - Add several missing job events.
    - Set printer state to idle for fax queues/"retry-job" policy.

- cupsdStopJob() Only set printer-state to idle if it's processing -
cupsdStopPrinter() sets the state to stopped then calls cupsdStopJob().

- cupsdUpdateJob() Generate printer-state-changed events when
printer-state-reasons changes.

Open issue:
Normal exit case in cupsdFinishJob() ("Close out this job...") still is
not-quite-right - it calls cupsdCancelJob() which sets the state to
canceled and generates a job-canceled event, before resetting the job
state to IPP_JOB_COMPLETED. Either cupsdCancelJob() shouldn't generate the
job canceled event or the extra work it does (e.g. set
"time-at-completed", etc.) needs to be promoted to cupsdFinishJob().

Link: http://www.cups.org/str.php?L1954
Version: 1.2-current
Fix Version: 1.3-current (r5952)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: str1954-3.patch
URL: <https://lists.cups.org/pipermail/cups/attachments/20060914/58002102/attachment.ksh>


More information about the cups mailing list