[cups.bugs] [HIGH] STR #2693: restore texttops full functionality
Opher Shachar
ophers at ladpc.co.il
Tue Jan 29 12:10:30 PST 2008
DO NOT REPLY TO THIS MESSAGE. INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.
[STR New]
Hello,
Up to the current version in svn job.c has code to extract 'charset' from
the 'document-format' job attribute.
Look at job.c in the current trunk r7267 here:
http://svn.easysw.com/public/cups/trunk/scheduler/job.c
in the function start_job() you have:
<code>
attr = ippFindAttribute(job->attrs, "document-format",
IPP_TAG_MIMETYPE);
if (attr != NULL &&
(optptr = strstr(attr->values[0].string.text, "charset=")) != NULL)
snprintf(charset, sizeof(charset), "CHARSET=%s", optptr + 8);
else
{
attr = ippFindAttribute(job->attrs, "attributes-charset",
IPP_TAG_CHARSET);
snprintf(charset, sizeof(charset), "CHARSET=%s",
attr->values[0].string.text);
}
</code>
Yet, in version 1.3 and 1.4 all charset files, except utf-8, were removed
from data/ . Hence, texttops functionality is impaired.
To restore its version 1.2 functionality out-of-the-box all that is needed
is re-including the charset files from the 1.2 branch AND documenting this.
Regards,
Opher.
Link: http://www.cups.org/str.php?L2693
Version: 1.4-current
More information about the cups
mailing list