[cups.bugs] [LOW] STR #2929: cupsaddsmb: Infinite loop

Alex Mauer hawke at hawkesnest.net
Fri Sep 5 11:31:15 PDT 2008


DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

If any step in cupsaddsmb fails (e.g. wrong password for the user name,
user without SePrintOperatorPrivilege), it will just keep retrying
forever.

This can result in problems like locking yourself out very quickly.

It's especially bad since it produces no output if not in verbose mode, so
you can't tell that it's just trying the same thing over and over and will
never work.

It would be far better if cupsaddsmb would try only once, and report that
an error happened, and what that error was.  Even if it can't determine
the exact cause of the error, it would be better to display "There was an
error in adding the printer while trying to (upload the driver files|add
the driver|set the printer to use the driver)" and then halt.

Regardless of the error type, going into an infinite loop is the wrong
thing to do, especially given the potential self-DoS on the user account.

Link: http://www.cups.org/str.php?L2929
Version: 1.3.7





More information about the cups mailing list