[cups.bugs] [LOW] STR #3091: scheduler/job.c:load_job_cache() shouldn't discard attrs of completed jobs

[Michael R Sweet]

Lothar Brendel wrote:
> Hi Michael,
> 
>> Um, update_quotas() calls cupsdLoadJob() as needed when doing quota checks;
>>   
> I couldn't find any function called "update_quotas()" in the whole 
> source tree (of 1.3.9); do you refer to 
> scheduler/quotas.c:cupsdUpdateQuota()?

Yes, sorry.

> If yes: Um, how does it do that?? In scheduler/quotas.c there is no call 
> at all to cupsdLoadJob(), but cupsdUpdateQuota() just uses 
> ippFindAttribute() which returns immediately if the attrs pointer is NULL.

The following was added in r8296:

    /*
     * Make sure attributes are loaded; we always call cupsdLoadJob() to 
ensure
     * the access_time member is updated so the job isn't unloaded right 
away...
     */

     if (!cupsdLoadJob(job))
       continue;

which was in response to STR #3078 (so yours is a dupe, and I've
marked it as such...)

-- 
______________________________________________________________________
Michael R Sweet                        Senior Printing System Engineer