[cups.bugs] [LOW] STR #4067: Dead code in ipp_read_http()?

Edgar Fuß ef at math.uni-bonn.de
Tue May 1 03:56:08 PDT 2012


DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

I think there is dead code in ipp_read_http().

At cups/ipp.c:3146, there is a
    if (http->data_encoding == HTTP_ENCODE_CHUNKED)
clause that is itself wrapped inside a
    if (http->used > 0 && http->data_encoding == HTTP_ENCODE_LENGTH)
at cups/ipp.c:3117.
I cannot see how http->data_encoding may change in between other than a
memcpy() or memmove() going wild.

There's also a
    if (http->data_encoding != HTTP_ENCODE_CHUNKED)
at line 3156 that seems redundant.

Or what am I missing?

Link: http://www.cups.org/str.php?L4067
Version: 1.5.2





More information about the cups mailing list