[cups-devel] [UNKN] STR #4397: Build: cups requires libdispatch when blocks feature is enabled

[Pedro Giffuni]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Looking at the code in cups/cups.h (line 33):

#  ifdef __BLOCKS__
#    include <dispatch/dispatch.h>
#  endif /* __BLOCKS__ */

This is clearly wrong: while libdispatch usually uses a compiler with
blocks support, libdispatch is a library and it's use is not necessarily
tied to the language feature. FreeBSD added block support to gcc-4.2.1, and
just like Apple's GCC it is enabled by default. blib dipatch is available
as an option so there is a report of the of a problem when building
cups-client with Blocks [1].

Apparently just commenting out the header works. Is libdispatch really
required?

If libdispatch is required, or optionally useful, please add it to
configure.in and use an appropriate #ifdef, otherwise, just removing the
lines should make the code cleaner.

Thanks in advance,

Pedro.

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=188161

Link: https://www.cups.org/str.php?L4397
Version: 1.7.1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJTP2i0AAoJENujp6sI12IjbZEP/2brYFkBugpQflqVVYJTjI44
ZCks2lktNRV0mlIleHFMuWX2Ks1ZKLKlAB0NorzViJ3QyWRFSBeBuyo0Gi6BgWJr
jCh71eP2j3T30P2CkVl0nySYMZblmNctVRoQgLm8gp6z9Gadntym89wpAeFmA/j4
3AUFpcDyHy9DHl4IlnuVbJRJPkHhMD6fzlcaV1KVAOMhYCUKrffR73TwO7Ncrtx6
oc1VgzD9Vz21EoQenaiGm7RoF1U9WtKeTBCXP3/TkXPu5uadH+7oQTCFKdkl4DnY
0VOxvaW6u65o2XZtbF+VApyXIGisA9cfduKWA2XH6W8/agf6l1ULfisQCjk15+xV
DN7ukP1p1pAb4HOKVpdfKZYBHA60pdKgywVyPYjIKG5r+cTv88fjk1joCrucrdx3
pJcg2dQOLylK7/rGynsPOpNCcFqEyKgP65D51ic3BLeE+MiP752DN4K7mC0OxAg4
sb027/HKlntND/1YWHR0/RotiDftLmzskdIB71RoUQrUDw7AOsX/hM7iEKpS3l89
4G025ywq1uYt1Jy0pkdUvq4oUv2IYN+qLRAdv3jIcrgU5IF+i4S+PAI3oyqZb0CY
SlbwAFFyI/VdAwg43OHIb3ioabX1pSlRXGeEgJuZkilvyjVJJREWNv2GYlkZnfbQ
ZX/tQCw6rNY4mjHBkIeJ
=laJC
-----END PGP SIGNATURE-----