[cups-devel] [LOW] STR #4452: LPD breaks when bind fails from oversize address_len (new glibc)

[Natanael Copa]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR Resolved]

Linking lpd...
lpd.o: In function `lpd_queue':
lpd.c:(.text+0x3ff): undefined reference to `httpAddrLenght'
collect2: error: ld returned 1 exit status

Where is httpAddrSize defined?

Are you sure you don't mean httpAddrLength instead?

diff --git a/backend/lpd.c b/backend/lpd.c
index 48d1a5f..0a1bd1e 100644
- --- a/backend/lpd.c
+++ b/backend/lpd.c
@@ -1269,7 +1269,7 @@ rresvport_af(int *port,                   /* IO -
Port num
     * Try binding the port to the socket; return if all is OK...
     */
 
- -    if (!bind(fd, (struct sockaddr *)&addr, httpAddrSize(&addr)))
+    if (!bind(fd, (struct sockaddr *)&addr, httpAddrLength(&addr)))
       return (fd);
 
    /*

Link: https://www.cups.org/str.php?L4452
Version: 1.7-current
Fix Version: 2.0-current (r12004)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJTxPRtAAoJENujp6sI12IjJX8P/iFb4kmR74ej3IZ4bmPYNpUc
dbFddrQyQSeqzI4ZMnhP+HDR86PPayW+82/XUENh/3xrJrmFir42DKoKwUfuXRpV
Hg5pRQVb0s4rn1t+HyBA+pjZaEEFNvV45fpiRX61+kVgJP3gmwnkOpCEwOQWnhkC
OYhxcSR/OUrhJb1kbfQs9JRSH4+IIBgj5LHLnB5xL9lXfyKntiZHGrg8yNkTkHcD
dOFJcZuaRrAv3xNrtZRAVaq8aFEKcjl7QOB+Ww3a36BlEc3e4gwzAvELpbySI2Kc
dQkJhHaIWEF6rFB2qtLu4bb70JncSB7vD9X2uvV/2KidVAhz+rMpfajrzqUzSBRH
9gnRM/aiUz7jDIuDw15/TdHzquO3FS/OfAIlUdf3Ixi6Bdd8CDvsgqxvxbZE92Zq
1l/rxBM6L2z2fJqMkteMakOUbtJGm+0l4TTuOuPK172NNB5/u3Qt2QzGIi4N7GG7
J+HdXpnIQcwjsbIlW/TaPCHqeCefamx0YD2F6ERJWuVZr80YmzTLSbXPOOPpeeQF
76ZeTd7wrRu7jVoBzn2xNuGn3e/FSxerO8s5XLq6XsrQeusLOXsMiLcTl/EnlDI8
4776wyxHXdLnY8g3QNbuEoEQXapCg+5oJTtlfThjmnBoJeiKLtLgg61J00YAy2kI
EE39PrOdXxHqjfCDvbjm
=o6Tl
-----END PGP SIGNATURE-----