[cups-devel] [UNKN] STR #4567: util.c: ippAddStrings(... IPP_TAG_NAME, "requested-attributes" ...

[Johannes Meixner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

It seems since the beginning of CUPS there is
in cups/util.c one case of this form

  ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                "requested-attributes",

I found it in cups-1.1.20 cups-1.1.23 cups-1.3.9 cups-1.5.4
cups-1.7.3 cups-1.7.4 cups-1.7.5 cups-2.0.0 cups-2.0.1

Everywhere else I find only that form

  ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
                "requested-attributes", ...

I think IPP_TAG_KEYWORD must be used in any case for
"requested-attributes".

I also found
http://cups.org/pipermail/cups/2013-February/025818.html
where Till had also used IPP_TAG_NAME for "requested-attributes".

This may indicate wrong documentation somewhere (perhaps a wrong example?).

Link: https://www.cups.org/str.php?L4567
Version: 2.0-current
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJUyl+CAAoJENujp6sI12IjeuQP/A5Phy/g0wRpEF4JqkmndpEG
CR8Oljcn0H1mbS8SApByfSYkG+oOJAB5f/GC1urebvehnV1tKSbN0TPAII2AHAI5
+jEvRXwTpdlh2Fk7IGipifsvEcAzKgsGUIL9yj9D1Bl+vCszjr76KW49n/EyHMoX
stYLUpgaIJTMZ1j/2V2uk7hxye034YawVIlGf73kcYTlggpCN4hRVl+Csec2OE/P
xIp2IAiMHcuBo01VhC+iDDnrFjd7kRfR/9sqRC97aMhLN/aQLV+GC3NaiDoCq3Nt
LW4f9GAvUIlj91OGpyR+ay7LwP7RmnqHJmSuVXbq6Rgc0AVvVTO6/L5HiOolzSvl
agNkdMi5Dx28rM0u4e1FfaIvtFBIgP6Uxc8yP90RffVBvyzR3GX/Azzv8XGm0GUZ
MnIau7vTOVVkOGd7Uqt0quLDObF6ejUbc3xStwFCbthxOUb0AJm66qE9ulLc+ehc
Bvz6YpPVCDD3gI2ybtyhJ7QEhxw4gt+cCVmzIIOTxVdkF2ll9YC5As1coOflP9sg
QHrKlSYoPQ1sIx17+yiaTtnJZZzzgBUsY38d70l8kKGUeL8av481o+Nmqp6Py40o
bHGsgGjs4tEXvJfb3gGcrVBM6zBYOKOlvyjREK/mld+8ZAoVVNAjmMvmlF+9Szhy
6OwX3n2wwfLc3zvfIc4l
=Fs18
-----END PGP SIGNATURE-----