[cups-devel] [UNKN] STR #4672: Completion of error handling

[Markus Elfring]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

I have looked at a few source files for your current software. I have
noticed that some checks for return codes are missing.
http://cwe.mitre.org/data/definitions/252.html

Would you like to add more error handling for return values from functions
like the following?
* ippNewRequest ⇒ cupsGetDevices, httpAssembleURI
* sigaction ⇒ main

Link: https://www.cups.org/str.php?L4672
Version: 2.1b1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJVpSteAAoJENujp6sI12IjdVcP+wcDl9zo3l2mJfZpRNU8jsnn
MLeJfhg5+0lHSIpuKwxKSrtcfQDoaToL77wuf7r0Hd6SUyUZUiqq/Oc4uCvzEynL
ymuun2cnqf5x6C4lws61CQgSUOwRuxXsAZ4vV6COB3gKzrXZLcz5FQDUnYe/jEGP
WKWuAkCTkvGPp4IGIJ/K7I3qgkoOmOcM7Dh6Ty78mNQffqZBM5MN5NT8Mxdp7Wyl
6Ni40TAgijMm5X/DKsnCwydsdb2ce2itaSeoFQJf4x7sO0M+EqxIEtkZWIa9mlNo
KxgaM2jsaMXxrA+Y2maF3AyigGuFRZsN03pg9SBFEI+cXDu+E5aJW2UHP/aad6DS
bSKxGsIh3XWzRBB8SLie3ldLr66PewZ6hdO85/0AupvpGBDjz3zhX5IMA1s89KaQ
WcjMqR8pLrg2EhJMZTJNvk8tOGf4s3550vrHMsmerMg1KlCbzHHoaAoKLn5U2IwS
9IJ6lEl5EmWYYzdxhB2rVwA4BkOGeBpYdWN34ZP7MWmFhLuXs2fZ1Ir9z9EjsQkC
v/y1g8KvNtXnVvOsb6KdMHaAsUp7Sz7NjBjKoagZxZplpF8ko9oUieVK0V5tUYYX
sw0KbnQTnc45mnpK/RLFCrjvnbC1XDNvEtoC6oe07p+pDo3eNycZZnE1WHAafY4K
q+o6zYrqX9Wn/FogRrpR
=scXA
-----END PGP SIGNATURE-----