[cups-devel] [UNKN] STR #4634: [PATCH] [cups-2.1] cupsConnectDest(): addrlist is leaking after successful httpConnect2()

[Roman Lebedev]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

I was working on fixing all memleaks i can in darktable, and i found this:

Direct leak of 12808 byte(s) in 1 object(s) allocated from:
    #0 0x7ffb35bc4895 in calloc
(/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7ffb2e58073c (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x3073c)
    #2 0x7ffb2e5834f0 in httpConnect2
(/usr/lib/x86_64-linux-gnu/libcups.so.2+0x334f0)
    #3 0x7ffb2e5739df in cupsConnectDest
(/usr/lib/x86_64-linux-gnu/libcups.so.2+0x239df)
...

That happens even if the http_t* returned from cupsConnectDest() is
correctly passed to httpClose().

I have checkout most recent git version:
http://www.cups.org/cups.git cups-2.1,
commit cab9f682cddee9b67a567ed719576e758eb61095
git-svn-id: svn+ssh://src.apple.com/svn/cups/cups.org/trunk@12659
a1ca3aef-8c08-0410-bb20-df032aa958be

And looks like that the issue is still there, so i have prepared a patch.

Link: https://www.cups.org/str.php?L4634
Version: 2.0-current
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJVYJMdAAoJENujp6sI12IjHqkP/Rc6ylppk2DApqiPUUxaLIDl
oq5xTScRk8BpP8Scjbuy8yXDNs2Zzot7oeWvG1L+8g7WrTDh/g3XWju3EIC8GZiC
K5m0TAska8Qtko+7MHIEujxOgGDiWJ6Xd/3wzIhBsQAc0DRTXwxgdi0dtuc51mvQ
V+GlWFhlF298vgmG57pP/dZR5Nu6Kqntm/NJcqgCBdP/FTVdbDTER9V414/dq3Oc
CHoTeiSLlCeEO6Xh6s5ro2Zz8yrb+rtPAmnFMiL4bWfHXIOZ39KvOQ/bB1tDDA3L
/ojAzufNfraRxvZt7CB9S0YrDcg5dPSmINt+5CwF1mohJ8Oq8ilqRIX94TqLgU/5
TotQsj64Q1ZMUoRUZmLRQD8R/O98ITuf1F6ZHkDcwhQEUG0zZn8rxpODNtEdGJHz
YcFinqP6YiwyZnSUl1cNXQaI3eylkQ02X3PhdyEe2qffxNOXsFy5Km5inwke9Wuv
Fu5qV6wS+6eFd28kEzl602EdAAZ9WxBHv0Ok40NnMv53NY8VZq/ozRuA93gRKsjq
5bnjUc/1B6j/qUAx4NI9hkbR64U41W4tGQbg845s2IOOCHc+PbcgVvF+tr5s8dgd
be6aQod+ytBF4fzoyyarctF4lx8k3Rg81UZc/1VcuYu+RscNM3cvOW5bvRKyIkyB
tfOaHKSTw8YTxlxFTUSH
=hJ84
-----END PGP SIGNATURE-----